leanprover / leanprover/lean4

`rw` duplicates goals

Open
#6,407 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug P-low
Dominant language
Lean
Stars
9.2k
Forks
990
Avg merge
1d 17h
Merged PRs (30d)
175

Description

Prerequisites

Please put an X between the brackets as you perform the following steps:

Description

The rw tactic sometimes duplicates the same MVarId in the list of goals

Context

[Broader context that the issue occurred in. If there was any prior discussion on the Lean Zulip, link it here as well.]

Steps to Reproduce

Run

theorem duplicate_goal : ∃ a : Int, a = 1 := by
  refine ⟨?_, ?_⟩
  rotate_left
  rw [eq_comm]
  -- three goals
  sorry
  -- two goals
  sorry
  -- zero goals

Expected behavior: There should be two goals after the rw

Actual behavior: The goal state after the rw is

case refine_2
⊢ 1 = ?refine_1
case refine_1
⊢ Int
case refine_1
⊢ Int
Versions

4.15.0-rc1

Additional Information

[Additional information, configuration or data that might be necessary to reproduce the issue]

Impact

Add 👍 to issues you consider important. If others are impacted by this issue, please ask them to add 👍 to it.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by running the provided duplicate_goal theorem against Lean 4.15.0-rc1 and inspect the rw [eq_comm] goal state after rotate_left. Trace the rw tactic's goal handling to find why one MVarId is emitted twice. Done means the example produces two goals after rw, without relying on Mathlib or Batteries.

Written by the indexing model from the issue text.

Assessment

Domain
compilers
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.