`simp?` after a focus dot produces incorrectly indented lines
Nobody has claimed this yet.
- Dominant language
- Lean
- Stars
- 9.2k
- Forks
- 990
- Avg merge
- 1d 17h
- Merged PRs (30d)
- 175
Description
Prerequisites
Please put an X between the brackets as you perform the following steps:
- Check that your issue is not already filed:
https://github.com/leanprover/lean4/issues - Reduce the issue to a minimal, self-contained, reproducible test case.
Avoid dependencies to Mathlib or Batteries. - Test your test case against the latest nightly release, for example on
https://live.lean-lang.org/#project=lean-nightly
(You can also use the settings there to switch to “Lean nightly”)
Description
When simp? appears directly after a focus dot, clicking on the "Try this:" suggestion inserts code where the second and following lines are at the same indentation as the first, instead of indented by two additional spaces.
MWE:
@[simp]
theorem a_lemma_with_a_very_loooooooooooooooooooooooooooooooooooooooooooong_name (n : Nat) :
2 * n = n + n := by
exact Nat.two_mul n
@[simp]
theorem another_lemma_with_a_very_loooooooooooooooooooooooooooooooooooooooooooong_name (n : Nat) :
1 + n = n + 1 :=
Nat.add_comm ..
example (n : Nat) : 1 = 1 ∧ 1 + 2 * n = n + n + 1 := by
constructor
· rfl
-- · simp? -- and then clicking on "Try this:" gives
· simp only [a_lemma_with_a_very_loooooooooooooooooooooooooooooooooooooooooooong_name,
another_lemma_with_a_very_loooooooooooooooooooooooooooooooooooooooooooong_name]
Context
See the discussion on Zulip.
Steps to Reproduce
See the MWE above.
Expected behavior:
The second and following lines of the inserted code should be indented by two additional spaces.
Actual behavior:
All lines have the same indentation.
Versions
Lean 4.14.0-rc2
Target: x86_64-unknown-linux-gnu
Impact
Add 👍 to issues you consider important. If others are impacted by this issue, please ask them to add 👍 to it.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the MWE with Lean 4.14.0-rc2, placing simp? after the focus dot and clicking the “Try this:” suggestion. Trace the focus-dot suggestion insertion path and verify that the second and following inserted lines are indented two spaces further than the first, as shown in the expected behavior.
Written by the indexing model from the issue text.
Assessment
- Domain
- developer-experience, tooling
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100