Sum.elim_map should be simp
Nobody has claimed this yet.
- Dominant language
- Lean
- Stars
- 9.2k
- Forks
- 990
- Avg merge
- 1d 17h
- Merged PRs (30d)
- 175
Description
Prerequisites
Please put an X between the brackets as you perform the following steps:
- Check that your issue is not already filed:
https://github.com/leanprover/lean4/issues - Reduce the issue to a minimal, self-contained, reproducible test case.
Avoid dependencies to Mathlib or Batteries. - Test your test case against the latest nightly release, for example on
https://live.lean-lang.org/#project=lean-nightly
(You can also use the settings there to switch to “Lean nightly”)
Description
Sum.elim_map isn’t @[simp] but arguably could and should be?
Context
This came up in a debugging session during office hours, where a in a somewhat complicated proof I spotted Sum.elim … (Sum.map …), and maybe if simp simplified that right away (as was the expectation of the user) it might have saved us.
The similarity to List.map_map indicates that it’s not unreasonable.
Versions
7dc1ceb8d4312850b39cef9e751e0a3b651946e3
Impact
Add 👍 to issues you consider important. If others are impacted by this issue, please ask them to add 👍 to it.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the Sum.elim_map declaration linked from Init/Data/Sum/Lemmas.html and inspect nearby simplification lemmas. Try a minimal Lean example using simp, then verify that the requested attribute produces the expected simplification without unwanted behavior.
Written by the indexing model from the issue text.
Assessment
- Domain
- compilers
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100