leanprover / leanprover/lean4

`Membership.mem` does not work in `calc` unless the calc lines are swapped

Open
#6,042 1 comment 6 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug P-low
Dominant language
Lean
Stars
9.2k
Forks
990
Avg merge
1d 17h
Merged PRs (30d)
175

Description

Prerequisites

Please put an X between the brackets as you perform the following steps:

Description

This occurred after #5020. The arguments of Membership.mem was swapped there, but calc has not adapted to this change, so expected proofs do not work.

Context

The discussion on the Lean Zulip.

Steps to Reproduce

Consider the following code:

example {G : Type} {P : Type} [Membership G P] (H : P) (a b : G)
    (h₁ : a = b) (h₂ : a ∈ H) : b ∈ H :=
  calc
    b = a := h₁.symm
    _ ∈ H := h₂

Expected behavior:

The proof works.

Actual behavior:

We get an error at the line _ ∈ H := h₂ with the following message:

invalid 'calc' step, left-hand-side is
  H : P
previous right-hand-side is
  a : G

Instead of the above proof, a proof with the swapped calc lines works:

/- Valid proof -/
example {G : Type} {P : Type} [Membership G P] (H : P) (a b : G)
    (h₁ : a = b) (h₂ : a ∈ H) : b ∈ H :=
  calc
    a ∈ H := h₂
    a = b := h₁
Versions

"4.15.0-nightly-2024-11-11"
(live.lean-lang.org.)

Impact

Add 👍 to issues you consider important. If others are impacted by this issue, please ask them to add 👍 to it.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the minimal reproducer in the issue and inspect the calc elaboration handling of Membership.mem, alongside the argument change from #5020. The fix is complete when the original calc proof typechecks without swapping its lines, while the existing swapped form continues to work.

Written by the indexing model from the issue text.

Assessment

Domain
compilers
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
39/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.