leanprover / leanprover/lean4

`@[local ext]` should not generate a global `ext_iff` lemma

Open
#5,978 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug P-medium
Dominant language
Lean
Stars
9.2k
Forks
990
Avg merge
1d 17h
Merged PRs (30d)
175

Description

Prerequisites

Please put an X between the brackets as you perform the following steps:

Description

Tagging a structure Foo with @[local ext] generates global Foo.ext and Foo.ext_iff. It seems better to generate them as private lemmas instead.

Context

Zulip

Steps to Reproduce

In file MWE:

@[local ext]
structure Foo where
  toNat := Nat

In another file,

import MWE

#check Foo.ext
#check Foo.ext_iff

Expected behavior: The #checks fail

Actual behavior: They succeed

Versions

4.14.0-rc2
Ubuntu

Impact

Add 👍 to issues you consider important. If others are impacted by this issue, please ask them to add 👍 to it.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the behavior using the MWE file and the separate file containing the import and #check commands. Trace the handling of the local ext attribute, then verify that the #check commands fail after the change while local ext functionality still works.

Written by the indexing model from the issue text.

Assessment

Domain
compilers
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.