`@[local ext]` should not generate a global `ext_iff` lemma
Nobody has claimed this yet.
- Dominant language
- Lean
- Stars
- 9.2k
- Forks
- 990
- Avg merge
- 1d 17h
- Merged PRs (30d)
- 175
Description
Prerequisites
Please put an X between the brackets as you perform the following steps:
- Check that your issue is not already filed:
https://github.com/leanprover/lean4/issues - Reduce the issue to a minimal, self-contained, reproducible test case.
Avoid dependencies to Mathlib or Batteries. - Test your test case against the latest nightly release, for example on
https://live.lean-lang.org/#project=lean-nightly
(You can also use the settings there to switch to “Lean nightly”)
Description
Tagging a structure Foo with @[local ext] generates global Foo.ext and Foo.ext_iff. It seems better to generate them as private lemmas instead.
Context
Steps to Reproduce
In file MWE:
@[local ext]
structure Foo where
toNat := Nat
In another file,
import MWE
#check Foo.ext
#check Foo.ext_iff
Expected behavior: The #checks fail
Actual behavior: They succeed
Versions
4.14.0-rc2
Ubuntu
Impact
Add 👍 to issues you consider important. If others are impacted by this issue, please ask them to add 👍 to it.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the behavior using the MWE file and the separate file containing the import and #check commands. Trace the handling of the local ext attribute, then verify that the #check commands fail after the change while local ext functionality still works.
Written by the indexing model from the issue text.
Assessment
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 42/100