incorrect hover type for array in syntax quote destruct
Open
Nobody has claimed this yet.
bug
P-low
- Dominant language
- Lean
- Stars
- 9.2k
- Forks
- 990
- Avg merge
- 1d 17h
- Merged PRs (30d)
- 175
Description
Prerequisites
Please put an X between the brackets as you perform the following steps:
- Check that your issue is not already filed:
https://github.com/leanprover/lean4/issues - Reduce the issue to a minimal, self-contained, reproducible test case.
Avoid dependencies to Mathlib or Batteries. - Test your test case against the latest nightly release, for example on
https://live.lean-lang.org/#project=lean-nightly
(You can also use the settings there to switch to “Lean nightly”)
Description
import Lean
open Lean Elab Tactic
syntax (name := just_print) "just_print" (ppSpace colGt term)* : tactic
@[tactic just_print]
def justPrintImpl : Tactic
| `(tactic| just_print $[$xs]*) => do
let xs : Array (TSyntax `term) := xs
logInfo f!"{xs}"
return
| _ => throwUnsupportedSyntax
Expected behavior:
hover xs : Array (TSyntax term)`
Actual behavior:
hover xs : TSyntax term`
Versions
4.10.0-rc2
macOS
Impact
Add 👍 to issues you consider important. If others are impacted by this issue, please ask them to add 👍 to it.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the minimal reproducer and the justPrintImpl syntax-quote destructuring shown in the issue. Trace how hover information is produced for the bound xs value, then reproduce the behavior on the reported Lean version or current nightly. Done means hovering xs reports Array (TSyntax term)rather thanTSyntax term.
Written by the indexing model from the issue text.
Assessment
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100