leanprover / leanprover/lean4

incorrect hover type for array in syntax quote destruct

Open
#5,915 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug P-low
Dominant language
Lean
Stars
9.2k
Forks
990
Avg merge
1d 17h
Merged PRs (30d)
175

Description

Prerequisites

Please put an X between the brackets as you perform the following steps:

Description
import Lean

open Lean Elab Tactic

syntax (name := just_print) "just_print" (ppSpace colGt term)* : tactic

@[tactic just_print]
def justPrintImpl : Tactic
| `(tactic| just_print $[$xs]*) => do
  let xs : Array (TSyntax `term) := xs
  logInfo f!"{xs}"
  return
| _ => throwUnsupportedSyntax
截屏2024-11-01 14 51 26

Expected behavior:

hover xs : Array (TSyntax term)`

Actual behavior:

hover xs : TSyntax term`

Versions

4.10.0-rc2

macOS

Impact

Add 👍 to issues you consider important. If others are impacted by this issue, please ask them to add 👍 to it.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the minimal reproducer and the justPrintImpl syntax-quote destructuring shown in the issue. Trace how hover information is produced for the bound xs value, then reproduce the behavior on the reported Lean version or current nightly. Done means hovering xs reports Array (TSyntax term)rather thanTSyntax term.

Written by the indexing model from the issue text.

Assessment

Domain
compilers
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.