`#check` does not issue deprecation warning or handle overloaded definitions
Nobody has claimed this yet.
- Dominant language
- Lean
- Stars
- 9.2k
- Forks
- 990
- Avg merge
- 1d 17h
- Merged PRs (30d)
- 175
Description
Prerequisites
Please put an X between the brackets as you perform the following steps:
- Check that your issue is not already filed:
https://github.com/leanprover/lean4/issues - Reduce the issue to a minimal, self-contained, reproducible test case.
Avoid dependencies to Mathlib or Batteries. - Test your test case against the latest nightly release, for example on
https://live.lean-lang.org/#project=lean-nightly
(You can also use the settings there to switch to “Lean nightly”)
Description
#check ident does not issue a warning if ident is deprecated. It also does not print all definitions of overloaded constants, and does not issue an error in this case.
Context
Steps to Reproduce
@[deprecated] def A := 0
@[deprecated] def B.A := 0
open B
#check A
Expected behavior: Warns that A is deprecated. Either raises an error that says A is overloaded or print types of both A and B.A. Both of these are done if the user does #check (A) instead.
Actual behavior: #check prints the type of B.A without warning
Versions
Lean version 4.13.0-rc3
Impact
Add 👍 to issues you consider important. If others are impacted by this issue, please ask them to add 👍 to it.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by running the minimal reproducer from the issue against the Lean nightly release and compare #check A with #check (A). Use the linked Zulip discussion for context. Done means deprecated identifiers produce a warning and overloaded definitions are either reported as ambiguous or both types are printed.
Written by the indexing model from the issue text.
Assessment
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100