leanprover / leanprover/lean4

rcases doesn't complain about unsynthesized placeholder

Open
#5,723 0 comments 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug P-medium
Dominant language
Lean
Stars
9.2k
Forks
990
Avg merge
1d 17h
Merged PRs (30d)
175

Description

Prerequisites

Please put an X between the brackets as you perform the following steps:

Description

If you write rcases x and x still has metavariables, this is not reported until the tactic is finished (and no new goals are generated for the metavariables)

Steps to Reproduce
example (p q : Prop) (h : Nat → p ∨ q) : True := by
  rcases h _ with h|h
  · trivial
  -- · trivial 
  -- if you uncomment the previous line, the expected error "don't know how to synthesize placeholder" is shown

Expected behavior: already display the error in the rcases tactic (or potentially create a new goal for it - maybe if you write ?_ for the metavariable)

Actual behavior: no warning/error (besides "unsolved goals")

Context

Zulip

This bug also affects cases' (from Mathlib)

Impact

Add 👍 to issues you consider important. If others are impacted by this issue, please ask them to add 👍 to it.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by running the minimal reproduction in the issue against the latest Lean nightly and compare the behavior of rcases with the commented line enabled. No source file or test path is named; investigate the rcases tactic behavior, including the related cases' case, and consider the issue done when the unsynthesized placeholder is reported during the tactic or becomes an explicit goal.

Written by the indexing model from the issue text.

Assessment

Domain
compilers
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.