leanprover / leanprover/lean4

Application type mismatch in simp involving dsimp theorem

Open
#5,702 1 comment 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug P-medium
Dominant language
Lean
Stars
9.2k
Forks
990
Avg merge
1d 17h
Merged PRs (30d)
175

Description

Prerequisites

Please put an X between the brackets as you perform the following steps:

Description

Internal error in simp. MWE:

def f (_ : List Empty) (b : Bool) := b

-- It matters that this is a `dsimp` lemma.
@[simp] theorem lem1 (a : Bool) : f [] a = a := rfl

@[simp] axiom lem2 (a b : Bool) (x y : List Empty)
  (h : f x a = f y b) : x = y

example : (([] : List Empty).take 0) = [] := by simp
/-
application type mismatch
  Eq.mpr (congrArg (fun x => f x (f ?y ?b) = f ?y ?b) List.take_nil) rfl
argument
  rfl
has type
  f ?y ?b = f ?y ?b : Prop
but is expected to have type
  f [] (f ?y ?b) = f ?y ?b : Prop
-/
Versions

"4.12.0-nightly-2024-10-13"

According to the original report, this is a regression from 4.11rc2.

Additional Information

Originally reported on Zulip.

Impact

Add 👍 to issues you consider important. If others are impacted by this issue, please ask them to add 👍 to it.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by running the self-contained reproducer from the issue against Lean nightly 4.12.0-nightly-2024-10-13 and a known-good 4.11rc2 to confirm the regression. Investigate the simp handling of dsimp lemmas, especially lem1 and lem2, and use the reported application type mismatch as the failure criterion. Done means the example no longer produces an internal error while preserving the intended simplification.

Written by the indexing model from the issue text.

Assessment

Domain
compilers
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.