leanprover / leanprover/lean4

Go to definition for `namespace` and `open` commands jumps to either nowhere or to the command definition

Open
#5,298 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug P-medium
Dominant language
Lean
Stars
9.2k
Forks
990
Avg merge
1d 17h
Merged PRs (30d)
175

Description

Prerequisites
  • Check that your issue is not already filed:
  • Reduce the issue to a minimal, self-contained, reproducible test case.
  • Test your test case against the latest nightly release, for example on
Description

The LSP "go to definition" does not properly go to definition for the namespace or open commands, and instead either will go nowhere or will jump to the definition of the namespace command itself.

(Whether this is a bug or an enhancement seems slightly subjective, so certainly no issue if it's classified as the latter)

Context

Mentioned here with minimal additional context.

Steps to Reproduce

Given a file containing:

-- import Lean
namespace Nat
end Nat

trying to jump to definition on Nat will either:

  • go nowhere if the import line is left commented out
  • jump to Lean/Elab/BuiltinCommand.lean if you uncomment the import (n.b. Mathlib has this import in its prelude, so essentially all Mathlib users see this half of the behavior more or less always)

The same behavior happens for open Nat.

Expected behavior: It would seem to me more expected that this should instaed be jumping to the definition of Nat (or whatever declaration is resolved by the namespace, if any) with or without the import.

Versions

[Output of #eval Lean.versionString]: "4.12.0, commit "
[OS version, if not using live.lean-lang.org.]: macOS 14.6.1

Additional Information
Impact

Add 👍 to issues you consider important. If others are impacted by this issue, please ask them to add 👍 to it.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the namespace and open examples in the issue, with and without the commented import, and inspect the go-to-definition behavior that currently reaches Lean/Elab/BuiltinCommand.lean. Done means both commands resolve the referenced namespace or declaration, including the no-import case described in the report.

Written by the indexing model from the issue text.

Assessment

Domain
compilers, devtools
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.