leanprover / leanprover/lean4

rw? sometimes inserts propext in suggestions

Open
#5,082 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

bug P-low
Dominant language
Lean
Stars
9.2k
Forks
990
Avg merge
1d 17h
Merged PRs (30d)
175

Description

Prerequisites

Please put an X between the brackets as you perform the following steps:

Description

The suggestions from rw? can contain unnecessary propext calls

Context

Found on zulip

Steps to Reproduce
import Mathlib
lemma theo1 (p : ℕ) (hp : p > 3) (hprime : Nat.Prime p) : ¬ (2 ∣ p) := by
  -- rw? finds:
  rw [propext (Nat.dvd_prime hprime)]

Expected behavior: output does not contain propext (for this suggestion, at least)

Actual behavior: it does

Versions

4.11.0-rc2 on live.lean-lang.org.

Additional Information

Apologies for the lack of reduction, I may have time to do that next week.

Impact

Add 👍 to issues you consider important. If others are impacted by this issue, please ask them to add 👍 to it.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reducing the rw? example in the Steps to Reproduce section and testing it against the latest nightly release. Investigate why the suggestion includes propext; done means a reproducible case and a suggestion that omits the unnecessary propext call.

Written by the indexing model from the issue text.

Assessment

Domain
compilers
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.