leanprover / leanprover/lean4

RFC: Deprecate `admit`

Open
#4,901 1 comment 20 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

P-low RFC
Dominant language
Lean
Stars
9.2k
Forks
990
Avg merge
1d 17h
Merged PRs (30d)
175

Description

Proposal

Currently, admit and sorry are synonyms.

If we deprecate the one that is less used, which is admit, beginners have one less thing to worry about what it does and if there's subtle differences to sorry.

Community Feedback

Deprecation suggested in this discussion after a beginner asked if there is a difference.

Impact

Add 👍 to issues you consider important. If others benefit from the changes in this proposal being added, please ask them to add 👍 to it.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files, tests, or implementation entry points are named. Start by tracing the existing definitions and usages of admit and sorry, then review the linked discussion for the intended deprecation behavior. Done means the proposal has an agreed scope and the resulting language, diagnostics, and documentation changes are covered.

Written by the indexing model from the issue text.

Assessment

Domain
compilers
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.