leanprover / leanprover/lean4

Can't add local attribute for namespaced theorem

Open
#4,744 2 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug P-medium
Dominant language
Lean
Stars
9.2k
Forks
990
Avg merge
1d 17h
Merged PRs (30d)
175

Description

Prerequisites

Please put an X between the brackets as you perform the following steps:

Description

The construction

@[local ...]
theorem Foo.bar ...

seemingly makes the attribute local to the Foo namespace, which is immediately closed again. Hence the attribute is effectively not applied.

Steps to Reproduce

MWE:

-- Fails

@[local simp]
axiom Foo.falso : False

example : False := by simp -- simp made no progress

-- Works

@[local simp]
axiom falso : False

example : False := by simp

I don't see a situation in which this behaviour would be useful, so the first example should imo either make the attribute local to the current section/namespace or throw an error at @[local simp]. There is probably a similar issue with scoped attributes; there the desired behaviour is less clear.

Versions

"4.11.0-nightly-2024-07-12"

Impact

Add 👍 to issues you consider important. If others are impacted by this issue, please ask them to add 👍 to it.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No source file or test is named. Start by running the two minimal Lean examples against the reported nightly behavior, then trace how @[local simp] is handled for namespaced declarations; done means the behavior is either corrected to keep the attribute local or rejected with a clear error.

Written by the indexing model from the issue text.

Assessment

Domain
compilers
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.