`textDocument/rename` does not rename occurrences of `hyp` after `tac at hyp` for `tac` = `rw`, `simp`, etc

Prerequisites

Please put an X between the brackets as you perform the following steps:

• Check that your issue is not already filed:
  https://github.com/leanprover/lean4/issues
• Reduce the issue to a minimal, self-contained, reproducible test case.
  Avoid dependencies to Mathlib or Batteries.
• Test your test case against the latest nightly release, for example on
  https://live.lean-lang.org/#project=lean-nightly
  (You can also use the settings there to switch to “Lean nightly”)

Description

In the following code, renaming the first occurrence of h renames all but the last occurrence. Renaming the last occurrence renames only the last occurrence.

example (h : True) : True := by
  rw [eq_true h] at h
  exact h

Probably anything that creates a new fvar with the same name (e.g. tac at hyp) has this behavior. I propose that even if they are different fvars they should be renamed together.

Similarly, if h is in Type I still propose all occurrences to be renamed rather than getting captured by the shadowed h✝.

Steps to Reproduce

1. Load the above code into a client that supports textDocument/rename (I'm not sure if live.lean-lang.org does, but vscode-lean4 does)
2. Try to rename any occurrence of h.

Expected behavior: All occurrences of h should be renamed.

Actual behavior: Either all but the last occurrence are renamed, or the only the last occurrence is renamed.

Versions

4.10.0-rc1

I can also reproduce it going back to 4.4.0 when the textDocument/rename capability was introduced.

Impact

Add 👍 to issues you consider important. If others are impacted by this issue, please ask them to add 👍 to it.

Start with the minimal Lean example in the issue and reproduce the behavior through a client supporting textDocument/rename, such as vscode-lean4. Trace the rename entry point and compare how occurrences are handled before and after rw, simp, or similar tactics create same-named hypotheses; done means every occurrence of the hypothesis is renamed without incorrect capture.