leanprover / leanprover/lean4

Roundtripping failure with `pp.analyze` and coercions

Open
#4,315 0 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug P-low
Dominant language
Lean
Stars
9.2k
Forks
990
Avg merge
1d 17h
Merged PRs (30d)
175

Description

Prerequisites

Please put an X between the brackets as you perform the following steps:

Description

The term 0 ≤ (↑n : Int) delaborates as 0 ≤ ↑n (with pp.analyze). This then re-elaborates as 0 ≤ n, so the coercion is lost:

import Lean

open Lean Lean.Meta Lean.Elab.Term Lean.PrettyPrinter in
#eval show TermElabM Unit from do
  withLocalDeclD `n (.const ``Nat []) λ _ => do
    let type ← elabTerm (← `(0 ≤ (↑$(mkIdent `n) : Int))) none
    synthesizeSyntheticMVarsNoPostponing
    let delabed ← withOptions (pp.analyze.set · true) $ delab type
    logInfo m!"delaborated: {delabed}"
    let type' ← elabTerm delabed none
    synthesizeSyntheticMVarsNoPostponing
    logInfo m!"re-elaborated: {type'}"
    logInfo m!"defeq: {← isDefEq type type'}"

/-
delaborated: 0 ≤ ↑n

re-elaborated: 0 ≤ n

defeq: false
-/
Context

I use the delaborator in aesop? to generate tactic scripts. Due to this issue, some of these tactic scripts don't elaborate correctly.

Brief Zulip discussion.

Versions

"4.9.0-nightly-2024-05-31"

Impact

Add 👍 to issues you consider important. If others are impacted by this issue, please ask them to add 👍 to it.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the reproducible TermElabM snippet using pp.analyze, delab, and elabTerm, then inspect the pretty-printer and elaborator paths involved in coercions. Done means the delaborated 0 ≤ ↑n re-elaborates with the coercion preserved and the final defeq is true.

Written by the indexing model from the issue text.

Assessment

Domain
compilers
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.