RFC(lake): Do not include missing files in `Some builds logged failures`
@tydeu is already working on this.
Since May 23, 2024.
- Dominant language
- Lean
- Stars
- 9.2k
- Forks
- 990
- Avg merge
- 1d 17h
- Merged PRs (30d)
- 175
Description
Proposal
Thanks to #4115, #3809 is solved! This is great, except that I noticed some rough edges in the new grouping. Here's one:
When running lake build in MyProject, the log ends with something like this:
Some builds logged failures:
- DependencyProject.Foo
- MyProject.Bar
- MyProject
I would hope this list is the list of files I need to fix. However, DependencyProject.Foo is not part of my project and does not even exist. The reason it's included in the list is because MyProject.Bar tries to import DependencyProject.Foo, but this information is already available to me via MyProject.Bar being in the list.
It's important that the output of lake build clearly pinpoints where the errors are, as this is what users like me look at to fix the build.
Community Feedback
Impact
Add 👍 to issues you consider important. If others benefit from the changes in this proposal being added, please ask them to add 👍 to it.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.