leanprover / leanprover/lean4

RFC(lake): Do not include missing files in `Some builds logged failures`

Open
#4,256 0 comments 3 reactions 1 assignee View on GitHub

@tydeu is already working on this.

Since May 23, 2024.

Lake P-medium RFC
Dominant language
Lean
Stars
9.2k
Forks
990
Avg merge
1d 17h
Merged PRs (30d)
175

Description

Proposal

Thanks to #4115, #3809 is solved! This is great, except that I noticed some rough edges in the new grouping. Here's one:

When running lake build in MyProject, the log ends with something like this:

Some builds logged failures:
- DependencyProject.Foo
- MyProject.Bar
- MyProject

I would hope this list is the list of files I need to fix. However, DependencyProject.Foo is not part of my project and does not even exist. The reason it's included in the list is because MyProject.Bar tries to import DependencyProject.Foo, but this information is already available to me via MyProject.Bar being in the list.

It's important that the output of lake build clearly pinpoints where the errors are, as this is what users like me look at to fix the build.

Community Feedback

Zulip

Impact

Add 👍 to issues you consider important. If others benefit from the changes in this proposal being added, please ask them to add 👍 to it.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.