Statically associate precedence with parsers
Open
Nobody has claimed this yet.
P-low
refactoring
- Dominant language
- Lean
- Stars
- 9.2k
- Forks
- 990
- Avg merge
- 1d 17h
- Merged PRs (30d)
- 175
Description
We noticed that we use non-initial checkPrecs only in two parsers: Type/Type u and Sort/Sort u. Arguably both of these should be split and checkPrec replaced with a precedence attribute parameter, which would simplify retrieving the precedence of a parser in both the pretty printer and the lhsPrec code.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the definitions and uses of the Type/Type u and Sort/Sort u parsers, then trace checkPrec into the pretty printer and lhsPrec code. The refactor is complete when those parsers use precedence attribute parameters and precedence retrieval is simplified in both consumers.
Written by the indexing model from the issue text.
Assessment
- Domain
- compilers
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100