Consider removing `Lean.RBMap.ofList`, `Lean.RBTree.ofList`
Nobody has claimed this yet.
- Dominant language
- Lean
- Stars
- 9.2k
- Forks
- 990
- Avg merge
- 1d 17h
- Merged PRs (30d)
- 175
Description
Prerequisites
- Put an X between the brackets on this line if you have done all of the following:
- Checked that your issue isn't already filed.
- Reduced the issue to a self-contained, reproducible test case.
Description
Lean.RBMap.ofList and Lean.RBTree.ofList are not tail recursive and hence susceptible to stack overflow. Lean.RBMap.fromList and Lean.RBTree.fromList already exist as tail recursive alternatives.
Versions
leanprover/lean4:nightly-2023-04-11
Additional Information
This came up in https://github.com/leanprover-community/mathlib4/pull/3507
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the definitions and uses of Lean.RBMap.ofList and Lean.RBTree.ofList, then compare them with the existing Lean.RBMap.fromList and Lean.RBTree.fromList alternatives. Check the mathlib4 pull request mentioned in the issue for context, and consider the work done when the redundant non-tail-recursive APIs are removed without breaking their callers.
Written by the indexing model from the issue text.
Assessment
- Domain
- compilers
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100