leanprover / leanprover/lean4

interpreter error from `import all` + `public import` allowing non-meta private def in public meta def

Open
#14,697 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Lean
Stars
9.2k
Forks
990
Avg merge
1d 17h
Merged PRs (30d)
175

Description

Prerequisites
Description

Private non-meta definitions in a module A can be used without immediate error in the bodies of public meta definitions in module B where B has public import A and import all A (and, notably, no meta import of A). The private def's IR is, as expected, not loaded when importing B normally downstream, which causes an interpreter error.

Steps to Reproduce

1. Create three files:

A:

module

def a (n : Nat) := n + 1

B:

module

public import A
import all A

-- No error:
public meta def b (n : Nat) := a n + 1

C:

module

import B

#eval b 5
  1. run lake build C (or equivalent) on the command line. (Do not open C in the language server; IR loading differs there, and no error is produced.)

Expected behavior: We have an error at b telling us that it improperly depends on a, and that we must include public meta import A (and maybe meta import all A as well as a matter of principle, even if not strictly necessary?)

Actual behavior:

error: C.lean:5:0: (interpreter) unknown declaration '_private.A.0.a'

Versions

4.34.0-nightly-2026-08-04, macOS

Additional Information

Note that if a were instead from the same module, it would be (correctly) rejected. I suspect that the assignment of IRPhases.all to the imported declaration a in B by getIRPhases (which therefore lets checkMeta treat it as an auxiliary def, look for it in the locally-produced decls, find nothing, and thereby succeed) might be incorrect. Even though the IRPhases of the module itself might be acceptable (we want to load the IR from import all'd modules for execution), I would expect that its declarations should retain their original IRPhases (unless we used meta import all) to make it "as if we were in the same module". (Currently getIRPhases just takes the IRPhases from the module's IRPhases without any questions asked.)

Or, maybe IRPhases is intended to fill a different role primarily (i.e. execution availability and not "reference" availability), and this is correct? I imagine that would mean checkMeta should have some extra branch, e.g. handling the case where getLocalDecl? returns none.

I'm sure there isn't a great need for me to propose solutions here, but I'm curious as to how this should be thought about. :)

Impact

Add 👍 to issues you consider important. If others are impacted by this issue, please ask them to add 👍 to it.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the three-file reproducer in A, B, and C, and run lake build C rather than using the language server. Read getIRPhases and checkMeta, focusing on how import all A and the private declaration a are classified. Done means the reproducer reports the invalid dependency at b instead of failing later with an interpreter unknown-declaration error.

Written by the indexing model from the issue text.

Assessment

Domain
compilers
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.