`debug_assert!` expression is not checked when `debugAssertions` is disabled
Nobody has claimed this yet.
- Dominant language
- Lean
- Stars
- 9.2k
- Forks
- 990
- Avg merge
- 1d 17h
- Merged PRs (30d)
- 175
Description
Prerequisites
- Check that your issue is not already filed:
https://github.com/leanprover/lean4/issues - Reduce the issue to a minimal, self-contained, reproducible test case.
Avoid dependencies to Mathlib or Batteries. - Test your test case against the latest nightly release, for example on
https://live.lean-lang.org/#project=lean-nightly
(You can also use the settings there to switch to “Lean nightly”)
Description
Currently with debugAssertions option disabled debug_assert! accepts everything that parses.
Steps to Reproduce
debug_assert! '1' + 2debugAssertionsoption is disabled
Expected behavior: macro throws an error signaling that the expression is invalid.
Actual behavior: macro discards the expression silently.
Versions
Lean 4.32.0
Additional Information
Equivalent macro in Rust always performs type checking.
Impact
Add 👍 to issues you consider important. If others are impacted by this issue, please ask them to add 👍 to it.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the minimal reproduction debug_assert! '1' + 2 in a Lean nightly environment, with debugAssertions disabled, and inspect the debug_assert! macro entry point and related tests. Confirm the behavior with the option both enabled and disabled. Done means the invalid expression is rejected even when assertions are disabled, while valid expressions retain the expected behavior.
Written by the indexing model from the issue text.
Assessment
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 65/100