leanprover / leanprover/lean4

Inconsistent spelling for cancellation

Open
#14,117 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug P-medium
Dominant language
Lean
Stars
9.2k
Forks
990
Avg merge
1d 17h
Merged PRs (30d)
175

Description

Description

We normally use US English for identifiers and docs, but parts of the library use UK English spellings for identifiers. In particular, IO.checkCanceled uses the US spelling, while Std.Async gives us isCancelled and Selector.cancelled with the UK spelling.

Impact

Add 👍 to issues you consider important. If others are impacted by this issue, please ask them to add 👍 to it.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the definitions and uses of IO.checkCanceled, Std.Async.isCancelled, and Selector.cancelled. Read nearby naming conventions and search the repository for both spellings. Done means the affected identifiers consistently follow the project's chosen spelling and all references remain valid.

Written by the indexing model from the issue text.

Assessment

Domain
compilers
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.