`pr-body` workflow doesn't pick up on labels added by `labels-from-comments` workflow
Nobody has claimed this yet.
- Dominant language
- Lean
- Stars
- 9.2k
- Forks
- 990
- Avg merge
- 1d 17h
- Merged PRs (30d)
- 175
Description
Prerequisites
- Check that your issue is not already filed:
https://github.com/leanprover/lean4/issues - Reduce the issue to a minimal, self-contained, reproducible test case.
Avoid dependencies to Mathlib or Batteries. - Test your test case against the latest nightly release, for example on
https://live.lean-lang.org/#project=lean-nightly
(You can also use the settings there to switch to “Lean nightly”)
Description
The pr-body workflow checks that a changelog- label is present; however, upon adding a changelog label through a comment, the workflow check isn't retriggered, meaning that you have to retrigger through other means, e.g. by pushing an empty commit or editing the PR description.
Context
This happened frequently to me (and also definitely others) but I always forgot to report it.
Steps to Reproduce
- Create a (non-draft) PR to this repository with the title starting with
featorfixand a description starting withThis PR. - Wait for the
pr-bodyworkflow to fail (this is expected) - Add a changelog label by sending a comment with the name of such a label, e.g.
changelog-library.
Expected behavior: The pr-body workflow gets rerun and succeeds.
Actual behavior: The pr-body workflow doesn't get run again, leaving it in a failed state, making it necessary to resort to other means (e.g. editing the PR description) to retrigger it.
Versions
N/A
Impact
Add 👍 to issues you consider important. If others are impacted by this issue, please ask them to add 👍 to it.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Inspect the GitHub Actions definitions for the pr-body and labels-from-comments workflows, then reproduce the sequence of a failed pr-body check followed by adding a changelog- label in a comment. Done means adding the label causes pr-body to run again and succeed without an unrelated PR change.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- github-actions
- Domain
- ci-cd
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100