leanprover / leanprover/lean4

Getting git repository as dependency does not include git submodules

Open
#10,467 2 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug P-low
Dominant language
Lean
Stars
9.2k
Forks
990
Avg merge
1d 17h
Merged PRs (30d)
175

Description

Prerequisites

Please put an X between the brackets as you perform the following steps:

Description

Getting a git repository as a dependency does not include git submodules

Lean does not call git clone --recursive when cloning a git repository
https://github.com/leanprover/lean4/blob/c6abc3c0368e10c49e9762fda1819ad0e95c9bb0/src/lake/Lake/Util/Git.lean#L65-L66

Context

#new members > Does importing dependency as git repository clone submodules

Steps to Reproduce
  1. Add git repository as dependency

Expected behavior: [Clear and concise description of what you expect to happen]
Includes submodule dependency

Actual behavior: [Clear and concise description of what actually happens]
Does not include submodule dependency

Versions

4.23, nightly

[Output of #version or #eval Lean.versionString]
[OS version, if not using live.lean-lang.org.]

Additional Information

[Additional information, configuration or data that might be necessary to reproduce the issue]

Impact

Add 👍 to issues you consider important. If others are impacted by this issue, please ask them to add 👍 to it.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at src/lake/Lake/Util/Git.lean around lines 65–66 and inspect how Lake clones git dependencies. Reproduce the dependency setup from the issue with a repository containing a submodule, then verify that fetching the dependency also includes the submodule.

Written by the indexing model from the issue text.

Assessment

Tech stack
git
Domain
build-system
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.