leanprover / leanprover/lean4

incremental elaboration of partial mutual definitions under the module system

Open
#10,348 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug P-high
Dominant language
Lean
Stars
9.2k
Forks
990
Avg merge
1d 17h
Merged PRs (30d)
175

Description

Prerequisites

Please put an X between the brackets as you perform the following steps:

Description

Consider the following code snippet:

module

abbrev CollectM := IO

partial def collectConst : CollectM Unit := do
  return ()

partial def collectExpr : CollectM Unit := do
  return ()

public partial def collectConstraints : IO (List Nat) := do
  return []

If we now edit this to

module

abbrev CollectM := IO

mutual

partial def collectConst : CollectM Unit := do
  return ()

partial def collectExpr : CollectM Unit := do
  return ()

end

public partial def collectConstraints : IO (List Nat) := do
  return []

By inserting first the mutual then the end Lean will complain that:

Unknown identifier `CollectM`

Note: A private declaration `CollectM` (from the current module) exists but would need to be public to access here.

In other words it now believes that collectConst and collectExpr are public. However if I restart the file it correctly detects that they are in fact not so this is likely a result of incremental elaboration in combination with the public partial def below.

Expected behavior: incremental elaboration does not show false visibility errors

Actual behavior: it does

Versions

Lean 4.24.0-nightly-2025-09-10
Target: x86_64-unknown-linux-gnu

Impact

Add 👍 to issues you consider important. If others are impacted by this issue, please ask them to add 👍 to it.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the minimal Lean snippet in the issue and reproduce it against Lean 4.24.0-nightly-2025-09-10 or the Lean nightly environment. Investigate incremental elaboration of the module containing the partial mutual definitions and later public partial definition; done means inserting mutual and end no longer produces the false CollectM visibility error.

Written by the indexing model from the issue text.

Assessment

Domain
compilers
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.