`lake setup-file` does not detect cycles with unsaved header
Open
Nobody has claimed this yet.
bug
P-medium
- Dominant language
- Lean
- Stars
- 9.2k
- Forks
- 990
- Avg merge
- 1d 17h
- Merged PRs (30d)
- 175
Description
Description
When adding an import cycle to a file without saving it, lake setup-file nevertheless succeeds, leading to spurious errors and panics in the editor.
Steps to Reproduce
- add
import Lean.CoetoInit/Prelude.lean - observe a barrage of error messages
- save file and refresh dependencies as suggested
- observe correct cycle error message
Impact
Add 👍 to issues you consider important. If others are impacted by this issue, please ask them to add 👍 to it.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the lake setup-file entry point and reproduce the unsaved Init/Prelude.lean import of Lean.Coe. Compare dependency refresh behavior before and after saving; done means the unsaved cycle is reported correctly without spurious editor errors or panics.
Written by the indexing model from the issue text.
Assessment
- Domain
- compilers, tooling
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100