leanprover / leanprover/lean4

Tactics can modify the elaborated types of theorems with let rec

Open
#10,252 5 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

bug P-medium
Dominant language
Lean
Stars
9.2k
Forks
990
Avg merge
1d 17h
Merged PRs (30d)
175

Description

Prerequisites

Please put an X between the brackets as you perform the following steps:

Description

Tactics within a proof can change the type of a theorem with let rec in.

Steps to Reproduce
import Mathlib

theorem ohno :
  ¬ ((let rec recur (n : Nat) : List Nat :=
      match n with
      | 0 => [1]
      | (Nat.succ n) => recur n
    recur 0 = [1])) ∧ True := by
        -- sorry
        refine Decidable.byContradiction fun h_contra => ?_
        apply h_contra
        constructor
        intro h
        apply_mod_cast h_contra
        any_goals tauto
        simp

theorem a : False := by
  have := ohno
  simp [ohno.recur] at this

Expected behavior: swapping the "proof" of ohno for "sorry" should not change the type of "ohno",

Actual behavior: when "ohno" is sorried out the type includes ohno.recur (and the following theorem is provable (ie ohno is false)). But when it is not sorried out Lean accepts the proof, which is fairly unintuitive.

on latest, I couldn't get rid of the Mathlib import easily but hopefully this is clear enough

Impact

Add 👍 to issues you consider important. If others are impacted by this issue, please ask them to add 👍 to it.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by running the issue's minimal reproduction and compare the elaborated type of ohno with and without its proof replaced by sorry. Investigate the interaction between let rec, theorem elaboration, and tactics; done means both forms preserve the same theorem type and the later ohno.recur use cannot change provability.

Written by the indexing model from the issue text.

Assessment

Domain
compilers
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.