leanprover / leanprover/lean-workbench
Processes are SIGKILLed on shutdown
Open
Nobody has claimed this yet.
enhancement
- Dominant language
- TypeScript
- Stars
- 9
- Forks
- 1
- Avg merge
- 2d 3h
- Merged PRs (30d)
- 35
Description
We send SIGTERM to the bwrap parent of vscode-server and collab-server processes when shutdown is requested, but SIGTERMing a bwrap just SIGKILLs the children which prevents graceful cleanup. We should track these children PIDs and SIGTERM them directly.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the shutdown handling and process-launch code for the bwrap parents of vscode-server and collab-server. Trace how child PIDs are currently managed, then verify that shutdown sends SIGTERM directly to those children and allows graceful cleanup.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- operating-systems
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100