leanprover / leanprover/lean-workbench
Vscode-server processes are not being killed
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 9
- Forks
- 1
- Avg merge
- 2d 3h
- Merged PRs (30d)
- 35
Description
We set a 1min timeout for extensionHost processes that are no longer seeing a client connection to be killed. These (more specifically their Lean server children) are the most memory-hungry processes, so this mostly suffices. However, the extensionHost's vscode-server parent should also be killed eventually, and yet it sticks around for a long time (or even indefinitely? not sure). We should reduce the timeout.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/lib/server/vscodeServer.ts around line 220, where the one-minute timeout for disconnected extensionHost processes is set. Trace how the timeout applies to the vscode-server parent, then adjust it so that parent is eventually killed as requested. Done means disconnected vscode-server processes no longer remain for a long time or indefinitely.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript, vscode
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 68/100