leanprover / leanprover/lean-workbench

Absence of `--unshare-net` is risky given the current design

Open
#16 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
9
Forks
1
Avg merge
2d 3h
Merged PRs (30d)
35

Description

We currently have servers running (openvscode-server, collaboration server) that trust incoming connections.

Without --unshare-net as a flag to all bubblewrap containers, this means that users' Lean code could make connections to these servers and violate important isolation assumptions. (e.g. "the only connections to the collaboration server are the intended ones mediated by our service")

However, with --unshare-net, users cannot make desirable network connections to the outside world, such as to download their own preferred vscode extensions and Lean packages.

A possible mitigation is as follows:

We must ensure that all servers in the system that listen on numbered ports perform authentication on all incoming connections.
We can migrate servers that don't expect to perform authentication on all incoming connections to listen only unix domain sockets which are excluded from bubblewrap containers by filesystem namespace isolation.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by inventorying the bubblewrap container flags and the servers that listen on numbered ports, including openvscode-server and the collaboration server. Done means every numbered-port server authenticates all incoming connections, or servers without that requirement listen only on Unix domain sockets excluded by filesystem namespace isolation.

Written by the indexing model from the issue text.

Assessment

Domain
backend, security
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
28/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.