leanprover / leanprover/fp-lean
Suggestion on Section 6.1, "Structures and Inheritance"
Nobody has claimed this yet.
- Dominant language
- Lean
- Stars
- 192
- Forks
- 73
- PR merge metrics
- No merged PRs in 30d
Description
This is a fantastic section. It was really fun and easy to read. In fact, it's so good I wished it had come sooner in the book!
Please consider having the initial inheritance section earlier (even Ch 1?). As a developer that's familiar with inheritance, I would have wanted to know about this sooner. The second half of the section (after "Default Declarations"), including the discussion of type classes and props seems to fit neatly in Ch 4 (perhaps somewhere after 4.3).
I feel that perhaps for people not already familiar with Functors/Applicative Functors/Monads (already being "scary" words), this section may take the focus away from the main topic.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review Section 6.1, “Structures and Inheritance,” including the point after “Default Declarations,” and compare it with Chapter 4 and section 4.3. Assess whether the inheritance material should move earlier and whether the type classes and props discussion belongs in Chapter 4; done means reaching and documenting an editorial decision.
Written by the indexing model from the issue text.
Assessment
- Domain
- documentation
- Issue type
- Documentation
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100