leanprover / leanprover/comparator
Comparator calls landrun with `--best-effort`
Nobody has claimed this yet.
- Dominant language
- Lean
- Stars
- 203
- Forks
- 36
- Avg merge
- 1h 40m
- Merged PRs (30d)
- 7
Description
Problem
Landrun's --best-effort silently degrades to the best available Landlock version. For Linux older than 5.13 (June 2021) this means it falls back to no Landlock protections at all.
See https://github.com/zouuup/landrun#best-effort-mode
Potential solutions
I think there are two main options to improve this without making changes to landrun:
- Comparator still passes
--best-effort, but refuses to run on very old versions of Linux, printing a descriptive error message. - Comparator does not pass
--best-effort. It thus requires Landlock >=v9, which was released with Kernel 7.1 in June 2026.
For more fine-grained control, a PR to landrun would be required.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the Comparator entry point that invokes landrun and review the five comments before choosing between the proposed approaches. Check how Linux and Landlock versions affect the invocation; done means an agreed behavior that avoids silently running without Landlock protection and reports the outcome clearly.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- linux
- Domain
- operating-systems, security
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100