leanprover-community / leanprover-community/physlib
Remove `erw`s
Open
Nobody has claimed this yet.
good first issue
help-wanted
- Dominant language
- Lean
- Stars
- 749
- Forks
- 189
- Avg merge
- 1d 21h
- Merged PRs (30d)
- 75
Description
There are lots of erw [...] in PhysLean. These are slow, and thus it is beneficial for them to be removed.
To remove an erw [...] usually means changing the corresponding lemma to simp-normal form.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Search the PhysLean source for erw [...] occurrences and inspect each corresponding lemma's simp-normal form. Update the affected Lean files so the targeted erw uses are removed, then verify those files build and that the intended occurrences no longer remain.
Written by the indexing model from the issue text.
Assessment
- Domain
- tooling
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100