leanprover-community / leanprover-community/physlib

Naming in Anomaly Cancellation for QED

Open
#1,046 3 comments 1 reaction 2 assignees View on GitHub

@jstoobysmith is already working on this.

Since Apr 20, 2026.

  • #1047 by @copilot-swe-agent — closed without merging
help-wanted
Dominant language
Lean
Stars
749
Forks
189
Avg merge
1d 21h
Merged PRs (30d)
75

Description

In ./Odd/BasisLinear and ./Even/BasisLinear, there is a poor choice of variable names splitting the two planes.

An example in the odd case is:

https://github.com/leanprover-community/physlib/blob/a6a22f98b9166549a8d268d38fa9f6ad0deb9108/Physlib/QFT/QED/AnomalyCancellation/Odd/BasisLinear.lean#L282-L291

compared to:

https://github.com/leanprover-community/physlib/blob/a6a22f98b9166549a8d268d38fa9f6ad0deb9108/Physlib/QFT/QED/AnomalyCancellation/Odd/BasisLinear.lean#L506-L515

There should be clearer descriptive naming around these planes. They should also be split into different file systems. The naming is tricky, but I think we should avoid something non-descriptive like plane1 etc.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.