leanprover-community / leanprover-community/mathlib4

RewriteSearch.lean flaky tests?

Open
#9,410 0 comments 0 reactions 1 assignee View on GitHub

@kim-em is already working on this.

Since Jan 3, 2024.

Dominant language
Lean
Stars
4.2k
Forks
1.7k
PR merge metrics
No merged PRs in 30d

Description

The tests/RewriteSearch.lean tests seem to be sensitive to some internal details, resulting in diffs like https://github.com/leanprover-community/mathlib4/pull/9409/commits/b4174684d8f5127db9c5204a65684499b0652251#r1440471803 . We should figure out what's going on here and either make the test more robust or fix rw_search.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.