leanprover-community / leanprover-community/mathlib4

register_simp_attr with

Open
#802 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Lean
Stars
4.1k
Forks
1.7k
PR merge metrics
No merged PRs in 30d

Description

In mathlib3 we wrote:

mk_simp_attribute monad_norm none with functor_norm

but register_simp_attr does not support a with clause.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the referenced mathlib3 example in src/control/monad/basic.lean around line 38, then locate the register_simp_attr command in mathlib4. Done means the command accepts the with functor_norm clause shown in the issue and registers it as expected.

Written by the indexing model from the issue text.

Assessment

Domain
tooling
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.