leanprover-community / leanprover-community/mathlib4
simps should dsimp the type of the new arguments
Open
Nobody has claimed this yet.
- Dominant language
- Lean
- Stars
- 4.1k
- Forks
- 1.7k
- PR merge metrics
- No merged PRs in 30d
Description
or maybe just dsimp the type in the loop. See https://github.com/leanprover-community/mathlib4/issues/7657#issuecomment-1779699650
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the simps tactic implementation and its existing tests, then read the discussion in issue 7657 and the referenced comment. Determine whether the new argument types should be dsimped in the loop or earlier, and add a regression test showing the intended simplification behavior.
Written by the indexing model from the issue text.
Assessment
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100