leanprover-community / leanprover-community/mathlib4

Deduplicate signs

Open
#7,842 2 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Lean
Stars
4.2k
Forks
1.7k
No merged PRs in 30d

Description

We have SignType.sign, Int.sign, and Real.sign.
Probably, we should deduplicate them.

  • Replace Int.sign (see loogle) with SignType.sign.
  • Replace Real.sign (see loogle) with SignType.sign.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the linked Loogle queries for Int.sign and Real.sign, then search the mathlib4 tree for their definitions and usages alongside SignType.sign. Determine the full replacement scope and verify that both APIs are consistently deduplicated without breaking affected references.

Written by the indexing model from the issue text.

Assessment

Domain
compilers
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.