leanprover-community / leanprover-community/mathlib4

local simp for simpsets

Open
#7,083 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Lean
Stars
4.1k
Forks
1.7k
PR merge metrics
No merged PRs in 30d

Description

This doesn't work:

attribute [local simp] parity_simps

The machinery only works for simps, not for simpsets. However, enabling a simpset within a scope is more powerful than enabling it in individual simp tactics, and is more convenient where the same simpset is used frequently. The semantics would be the obvious ones - if the attribute is applied to a simpset, then unroll it into an application for each lemma in that simpset.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue names no files or tests. Start by locating the handling for local simp and the representation of simpsets, then use parity_simps in a focused test. Done means applying [local simp] to a simpset expands it to each lemma for the enclosing scope.

Written by the indexing model from the issue text.

Assessment

Domain
tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.