leanprover-community / leanprover-community/mathlib4
Add `SubringClass.toNonUnitalSubringClass` and version for `SubsemiringClass`
Open
Nobody has claimed this yet.
enhancement
- Dominant language
- Lean
- Stars
- 4.1k
- Forks
- 1.7k
- PR merge metrics
- No merged PRs in 30d
Description
This issue has no description.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Search the mathlib4 source for SubringClass and SubsemiringClass and inspect nearby conversion APIs. Determine the corresponding declarations to add for toNonUnitalSubringClass, then verify that both new versions compile and match the surrounding API style.
Written by the indexing model from the issue text.
Assessment
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100