leanprover-community / leanprover-community/mathlib4
Reorganize Analysis.Calculus.ContDiff[Def]
Nobody has claimed this yet.
- Dominant language
- Lean
- Stars
- 4.2k
- Forks
- 1.7k
- PR merge metrics
- No merged PRs in 30d
Description
I noticed that some similar results are spread among these two files. The one that struck me is that ContDiffOn.fderivWithin is in ContDiffDef.lean while the corresponding ContDiffWithinAt.fderivWithin_right, ContDiffAt.fderiv_right and ContDiff.fderiv_right are all in ContDiff.lean. The naming inconsistency suggest that the API started diverging due to this split, which the last thing we want.
I think the solution is "simply" to go through these files and to check that all of the APIs (WithinAt, At, On and ) matched, and that these API are grouped together to minimize the risk of API divergence.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Compare Analysis/Calculus/ContDiffDef.lean and Analysis/Calculus/ContDiff.lean, starting with the listed ContDiffOn, ContDiffWithinAt, ContDiffAt, and ContDiff APIs. Check whether the WithinAt, At, On, and unrestricted APIs match and group corresponding results together; done means the two files no longer expose divergent organization or naming patterns.
Written by the indexing model from the issue text.
Assessment
- Domain
- developer-experience
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100