leanprover-community / leanprover-community/mathlib4
Rename `neg_nsmul` to `nsmul_neg`
Open
Nobody has claimed this yet.
- Dominant language
- Lean
- Stars
- 4.1k
- Forks
- 1.7k
- PR merge metrics
- No merged PRs in 30d
Description
The lemma says n • (-a) = -(n • a), so it should be named nsmul_neg. How should we call the existing nsmul_neg saying n • a < 0?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the declarations for neg_nsmul and the existing nsmul_neg, then review nearby naming conventions for the conflicting theorem names. Decide a non-conflicting name for the theorem about n • a < 0; done means the rename and replacement name are consistent across references and the relevant checks pass.
Written by the indexing model from the issue text.
Assessment
- Domain
- developer-experience
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100