leanprover-community / leanprover-community/mathlib4

Introduce a typeclass for a `ModelWithCorners` to be equal to `𝓘(𝕜, E)`

Open
#5,499 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Lean
Stars
4.1k
Forks
1.7k
PR merge metrics
No merged PRs in 30d

Description

This typeclass (with instances for modelWithCornersSelf,
ModelWithCorners.prod, and ModelWithCorners.pi) will allow us to
add generic to_space/from_space conversions to MDiffContAt etc
instead of formulating lemmas like MDiffContAt.prod twice.

There is a big flaw in this proposal: we still have non-defeq ChartedSpace instances.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Review the proposed typeclass together with the named instances modelWithCornersSelf, ModelWithCorners.prod, and ModelWithCorners.pi. Check whether the non-definitional-equality ChartedSpace instances prevent the intended generic to_space/from_space conversions for MDiffContAt; done means resolving that flaw or establishing a viable revised proposal.

Written by the indexing model from the issue text.

Assessment

Domain
tooling
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.