leanprover-community / leanprover-community/mathlib4

Redefine `Matrix.UnitaryGroup.toGL` etc

Open
#3,722 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Lean
Stars
4.1k
Forks
1.7k
PR merge metrics
No merged PRs in 30d

Description

We can golf this and related definitions a lot as explained in a porting note in the file. We shouldn't do this until after the port to avoid backporting it to Mathlib 3.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the file containing Matrix.UnitaryGroup.toGL and the related definitions, then read the porting note there. Verify that the port is complete before assessing the proposed golfing work; done means the related definitions have been compacted without requiring backporting to Mathlib 3.

Written by the indexing model from the issue text.

Assessment

Domain
tooling
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.