leanprover-community / leanprover-community/mathlib4

Follow-up of #29447: two more imports to remove

Open
#31,330 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Lean
Stars
4.1k
Forks
1.7k
PR merge metrics
No merged PRs in 30d

Description

After the huge work in #29447 refactoring and moving many things from NormedSpace to Normed as discussed in this issue two imports remain to be removed:

  1. import Mathlib.Analysis.Normed.Module.Basic inside Analysis/LocallyConvex/Polar.lean
  2. import Mathlib.Analysis.Normed.MulAction inside Analysis/LocallyConvex/Basic.lean (probably Normed.MulAction should be moved to Normed/Module/MulAction at any rate).

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read the referenced issues #29447 and #28698, then inspect the imports and surrounding declarations in Analysis/LocallyConvex/Polar.lean and Analysis/LocallyConvex/Basic.lean. Determine the dependencies that replace the two listed imports, and verify that both imports are removed; also assess whether Normed.MulAction belongs under Normed/Module/MulAction.

Written by the indexing model from the issue text.

Assessment

Domain
tooling
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.