leanprover-community / leanprover-community/mathlib4

Tactic for RingHom Properties

Open
#28,240 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement t-meta
Dominant language
Lean
Stars
4.1k
Forks
1.7k
PR merge metrics
No merged PRs in 30d

Description

Mathlib/RingTheory/RingHom/Flat.lean defines the property P := RingHom.Flat saying that a ring hom is flat, and proves properties about P such as P containing id, closed under comp, respects iso, and stable under base change.

I think the proofs of these are all rather standard and formulaic, e.g. the fact that flatness is stable under base change is already encoded in the theorem Module.Flat.baseChange [Flat R M] : Flat S (S ⊗[R] M).

I propose a tactic that will automate such proofs, so that the file will be able to be replaced with:

/-- A ring homomorphism `f : R →+* S` is flat if `S` is flat as an `R` module. -/
add_algebraize (mk_iff := true) RingHom.Flat Module.Flat

namespace RingHom.Flat

variable {R S T : Type*} [CommRing R] [CommRing S] [CommRing T]

/-- The identity of a ring is flat. -/
add_ring_hom_prop id Module.Flat.self -- generates ContainsIdentities too

/-- Composition of flat ring homomorphisms is flat. -/
add_ring_hom_prop comp Module.Flat.trans -- generates StableUnderComposition too

add_ring_hom_prop isStableUnderBaseChange Module.Flat.baseChange
add_ring_hom_prop holdsForLocalizationAway IsLocalization.flat
add_ring_hom_prop ofLocalizationSpanTarget Module.flat_of_isLocalized_span

/-- Bijective ring maps are flat. -/
@[ring_hom_prop respectsIso]
lemma of_bijective {f : R →+* S} (hf : Function.Bijective f) : Flat f := by sorry

end RingHom.Flat

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading Mathlib/RingTheory/RingHom/Flat.lean and the referenced Module.Flat.baseChange theorem in Mathlib/RingTheory/Flat/Stability.lean. Study the proposed add_ring_hom_prop and add_algebraize declarations in the issue, then determine whether the listed flatness properties can be generated. Done means the repetitive proofs are replaced by the proposed declarations and the file remains valid.

Written by the indexing model from the issue text.

Assessment

Domain
tooling
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.