leanprover-community / leanprover-community/mathlib4
Rename Counterexamples/OrderedCancelAddCommMonoidWithBounds.lean
Nobody has claimed this yet.
- Dominant language
- Lean
- Stars
- 4.2k
- Forks
- 1.7k
- PR merge metrics
- No merged PRs in 30d
Description
I think that Counterexamples/OrderedCancelAddCommMonoidWithBounds.lean should be renamed to reflect the new names of typeclasses (especially the new mixins for combining algebraic properties with orders).
Either way (even if the file itself doesn't get renamed), the docstring should be changed so that it doesn't refer to nonexisting typeclasses.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading Counterexamples/OrderedCancelAddCommMonoidWithBounds.lean and its docstring, then inspect nearby files for the current typeclass naming. Rename the file if the replacement is clear, or update the docstring at minimum so it refers only to existing typeclasses. Done means the file path and documentation consistently use current names.
Written by the indexing model from the issue text.
Assessment
- Domain
- documentation
- Issue type
- Documentation
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 50/100