leanprover-community / leanprover-community/mathlib4
Make `IsIdempotentElem` and `IsSelfAdjoint` 1-field structures
Open
Nobody has claimed this yet.
- Dominant language
- Lean
- Stars
- 4.2k
- Forks
- 1.7k
- PR merge metrics
- No merged PRs in 30d
Description
Doing so would allow for them to be extended, as would be applicable in, for example, #26052. This would allow us to avoid duplicating some API.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the definitions and usages of IsIdempotentElem and IsSelfAdjoint in mathlib4, then read issue #26052 for the motivating extension pattern. Check how their current APIs are used before changing their structure shape. Done means both are one-field structures that can be extended and avoid the duplicated API described in the issue.
Written by the indexing model from the issue text.
Assessment
- Domain
- tooling
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100