leanprover-community / leanprover-community/mathlib4

`rify` should work for `NNReal`

Open
#25,303 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement help-wanted please-adopt t-meta
Dominant language
Lean
Stars
4.2k
Forks
1.7k
PR merge metrics
No merged PRs in 30d

Description

rify should be enhanced so that something like the following can work. Zulip.

import Mathlib

example (a b : ℚ) : a + b + b = b + a + b := by
  rify
  ring

example (a b : NNReal) : a + b + b = b + a + b := by
  rify -- Simp made no progress

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the NNReal example in the issue and inspect the behavior of the rify tactic when simplification makes no progress. The work is done when the NNReal example succeeds with rify followed by ring, while the existing rational example continues to work.

Written by the indexing model from the issue text.

Assessment

Domain
tooling
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.