leanprover-community / leanprover-community/mathlib4
Uniformize APIs of `Polynomial` and `MvPolynomial`
Open
Nobody has claimed this yet.
t-algebra
- Dominant language
- Lean
- Stars
- 4.2k
- Forks
- 1.7k
- PR merge metrics
- No merged PRs in 30d
Description
Here's a (very) short table of mismatches because I don't have a ton of time, feel free to expand it whenever you find something.
Polynomial API |
MvPolynomial API |
|---|---|
| Polynomial.eval₂RingHom | MvPolynomial.eval₂Hom |
| Polynomial.hom_eval₂ | ??? |
| ??? | MvPolynomial.eval₂Hom_comp_C |
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by comparing the linked Polynomial and MvPolynomial API documentation, especially the eval₂ and composition declarations. Identify the corresponding mismatches and agree on the intended uniform naming and behavior; done means the relevant APIs are aligned and the comparison table is complete.
Written by the indexing model from the issue text.
Assessment
- Domain
- tooling
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100