leanprover-community / leanprover-community/mathlib4
simps: warning if attribute generates configuration in other file
Open
Nobody has claimed this yet.
- Dominant language
- Lean
- Stars
- 4.2k
- Forks
- 1.7k
- PR merge metrics
- No merged PRs in 30d
Description
If the @[simps] attribute (not the initialize_simps_projections command) generates the simps-projections AND the declaration was declared in a different file, we should probably raise a warning.
Reason: this is often done unintentionally.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the @[simps] attribute implementation and the initialize_simps_projections command, then trace where simps-projections are generated. Confirm how the declaration's file is identified and add coverage for the attribute case where the declaration is in another file; the command should not warn.
Written by the indexing model from the issue text.
Assessment
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100